Re: [COMMITTERS] pgsql: Allow external recovery_config_directory

From: Heikki Linnakangas <hlinnakangas(at)vmware(dot)com>
To: Simon Riggs <simon(at)2ndQuadrant(dot)com>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [COMMITTERS] pgsql: Allow external recovery_config_directory
Date: 2013-03-28 08:31:01
Message-ID: 5153FFC5.4000308@vmware.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

On 27.03.2013 23:36, Simon Riggs wrote:
> Why do you think recovery_config_directory are different to
> config_file with respect to pg_basebackup?

pg_basebackup doesn't try to *write* anything to config_file. It does
write to $PGDATA/recovery.conf, with the expectation that it takes
effect when you start the server.

When you take a backup, I think it's quite reasonable that if you have
set config_file to a different location, that's not backed up. Same with
recovery.conf. But when pg_basebackup *creates* recovery.conf, it's at
least surprising if it doesn't take effect.

- Heikki

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Simon Riggs 2013-03-28 09:18:40 pgsql: Revoke bc5334d8679c428a709d150666b288171795bd76
Previous Message Andrew Dunstan 2013-03-28 01:29:17 Re: pgsql: Set recovery_config_directory for EXEC_BACKEND.

Browse pgsql-hackers by date

  From Date Subject
Next Message Dean Rasheed 2013-03-28 09:34:01 Re: [PATCH] Exorcise "zero-dimensional" arrays (Was: Re: Should array_length() Return NULL)
Previous Message Konstantin Izmailov 2013-03-28 05:03:01 Re: [HACKERS] money with 4 digits after dot