Re: [COMMITTERS] pgsql: Improve concurrency of foreign key locking

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [COMMITTERS] pgsql: Improve concurrency of foreign key locking
Date: 2013-01-23 16:58:28
Message-ID: 510016B4.9070205@dunslane.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers


On 01/23/2013 10:12 AM, Alvaro Herrera wrote:
> Improve concurrency of foreign key locking

This error message change looks rather odd, and has my head spinning a bit:

- errmsg("SELECT FOR UPDATE/SHARE cannot be applied
to the nullable side of an outer join")));
+ errmsg("SELECT FOR UPDATE/SHARE/KEY UPDATE/KEY
SHARE cannot be applied to the nullable side of an outer join")))

Can't we do better than that?

(It's also broken my FDW check, but I'll fix that when this is sorted out)

cheers

andrew

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Andres Freund 2013-01-23 17:15:16 Re: [COMMITTERS] pgsql: Improve concurrency of foreign key locking
Previous Message Alvaro Herrera 2013-01-23 16:32:17 pgsql: isolationtester: add a few fflush(stderr) calls

Browse pgsql-hackers by date

  From Date Subject
Next Message Alexander Law 2013-01-23 17:06:01 Re: BUG #6510: A simple prompt is displayed using wrong charset
Previous Message Tom Lane 2013-01-23 16:58:04 Re: proposal: fix corner use case of variadic fuctions usage