From: | Jan Urbański <wulczer(at)wulczer(dot)org> |
---|---|
To: | "Karl O(dot) Pinc" <kop(at)meme(dot)com> |
Cc: | Oskari Saarenmaa <os(at)ohmu(dot)fi>, pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: [PATCH] PL/Python: Add spidata to all spiexceptions |
Date: | 2013-01-09 19:08:39 |
Message-ID: | 50EDC037.9080807@wulczer.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On 12/12/12 20:21, Karl O. Pinc wrote:
>>> There were 2 outstanding issue raised:
>>>
>>> Is this useful enough/proceeding in the right direction to commit
>>> now?
>>
>>> Should some of the logic be moved out of a subroutine and into the
>>> calling code?
>>
> I can see arguments to be made for both sides. I'm asking that you
> think it through to the extent you deem necessary and make
> changes or not. At that point it should be ready to send
> to a committer. (I'll re-test first, if you make any changes.)
Oh my, I have dropped the ball on this one in the worst manner possible.
Sorry!
I actually still prefer to keep the signatures of PLy_get_spi_sqlerrcode
and PLy_get_spi_error_data similar, so I'd opt for keeping the patch
as-is :)
Thanks,
Jan
From | Date | Subject | |
---|---|---|---|
Next Message | anarazel@anarazel.de | 2013-01-09 19:20:35 | Re: Re: [PATCH 1/2] Provide a common malloc wrappers and palloc et al. emulation for frontend'ish environs |
Previous Message | Tom Lane | 2013-01-09 19:07:58 | Re: Re: [PATCH 1/2] Provide a common malloc wrappers and palloc et al. emulation for frontend'ish environs |