From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | Peter Eisentraut <peter_e(at)gmx(dot)net> |
Cc: | Caleb Welton <cwelton(at)greenplum(dot)com>, pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: [PATCH] plpythonu datatype conversion improvements |
Date: | 2009-08-17 14:42:49 |
Message-ID: | 503.1250520169@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Peter Eisentraut <peter_e(at)gmx(dot)net> writes:
> The remaining problem is that the patch loses domain checking on the
> return types, because some paths no longer go through the data type's
> input function. I have marked these places as FIXME, and the regression
> tests also contain a failing test case for this.
For the record, I think this entire patch is a bad idea. PLs should not
be so much in bed with the internal representation of datatypes. To
take just one example, this *will* break when/if we change text to carry
some internal locale indicator. There has been absolutely zero evidence
presented to justify that there's a need to break abstraction to gain
performance in this area.
> What's needed here, I think, is an API that takes a datum plus type
> information and checks whether the datum is valid within the domain. I
> haven't found one that is exported, but maybe someone could give a tip.
There isn't one, but maybe you could expose domain_state_setup and
domain_check_input, or some simple wrapper around them.
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | Andrew Dunstan | 2009-08-17 15:04:02 | Re: [PATCH] plpythonu datatype conversion improvements |
Previous Message | Kevin Grittner | 2009-08-17 14:38:59 | Re: freezing tuples ( was: Why is vacuum_freeze_min_age100m? ) |