From: | John Naylor <jcnaylor(at)gmail(dot)com> |
---|---|
To: | pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: Review handling of MOVE and FETCH (ToDo) |
Date: | 2009-09-28 17:44:58 |
Message-ID: | 4d191a530909281044n418e885cvb219c7ab3e0013a4@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
(resent to -hackers)
I just applied and tested the new patch. Everything works great.
The only thing I would change now is some of the comments.
1). On line 289, one of the regression test comments got copied:
+ move forward in c; --should be at '5'
change to:
+ move forward in c; --should be at '1'
2). Lines 79/80:
+
errmsg("statement FETCH returns more rows."),
+
errhint("Multirows fetch are not allowed in PL/pgSQL.")));
This might sound better as "statement FETCH returns multiple rows.",
and "Multirow FETCH is not allowed in PL/pgSQL."
Everything else looks good to me.
John
> Hi Selena and John,
>
> Pavel's latest patch seems to address all the issues you raised in
> your initial review. Do you have any comments on this new revision?
> If you're happy that your issues have been resolved, please mark the
> patch as Ready for Committer.
>
> Cheers,
> BJ
>
From | Date | Subject | |
---|---|---|---|
Next Message | Jeff Davis | 2009-09-28 17:58:48 | Re: Issues for named/mixed function notation patch |
Previous Message | Tom Lane | 2009-09-28 17:44:12 | Re: syslog_line_prefix |