Skip site navigation (1) Skip section navigation (2)

Re: REASSIGN OWNED lacks support for FDWs

From: Etsuro Fujita <fujita(dot)etsuro(at)lab(dot)ntt(dot)co(dot)jp>
To: Alvaro Herrera <alvherre(at)commandprompt(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Robert Haas <robertmhaas(at)gmail(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: REASSIGN OWNED lacks support for FDWs
Date: 2012-02-23 08:37:27
Message-ID: 4F45FAC7.7020503@lab.ntt.co.jp (view raw or flat)
Thread:
Lists: pgsql-hackers
(2012/02/23 5:32), Alvaro Herrera wrote:
>> My only concern on the patch is
>>
>> +static void
>> +AlterForeignServerOwner_internal(Relation rel, HeapTuple tup, Oid
>> newOwnerId)
>> +{
>> +    Form_pg_foreign_server form;
>>
>> -    srvId = HeapTupleGetOid(tup);
>>       form = (Form_pg_foreign_server) GETSTRUCT(tup);
>>
>>       if (form->srvowner != newOwnerId)
>> @@ -366,10 +388,15 @@ AlterForeignServerOwner(const char *name, Oid
>> newOwnerId)
>>           /* Superusers can always do it */
>>           if (!superuser())
>>           {
>>
>> I wonder if superusers can always do it.  For example, is it OK for
>> superusers to change the ownership of a foreign server owned by old_role
>> to new_role that doesn't have USAGE privilege on its foreign data wrapper.
>
> Well, permission checking are just what they were before the patch.  I
> did not change them here.  I didn't participate in the discussions that
> led to the current behavior, but as far as I know the guiding principle
> here is that superusers always can do whatever they please.  Maybe what
> you point out is a bug in the behavior (both before and after my patch),
> but if so, please raise it separately.

OK.  Thanks.

Best regards,
Etsuro Fujita

In response to

pgsql-hackers by date

Next:From: Gianni CiolliDate: 2012-02-23 08:50:21
Subject: Re: Triggers with DO functionality
Previous:From: Simon RiggsDate: 2012-02-23 08:34:18
Subject: Re: VACUUM ANALYZE is faster than ANALYZE?

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group