From: | Jan Urbański <wulczer(at)wulczer(dot)org> |
---|---|
To: | Peter Eisentraut <peter_e(at)gmx(dot)net> |
Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: Potential reference miscounts and segfaults in plpython.c |
Date: | 2012-02-21 17:28:29 |
Message-ID: | 4F43D43D.7030801@wulczer.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On 21/02/12 18:05, Peter Eisentraut wrote:
> On sön, 2012-02-19 at 22:29 -0500, Tom Lane wrote:
>> My only comment is whether elog(ERROR) is appropriate, ie, do we
>> consider these to be internal errors that users will never see in
>> practice? If there's a significant risk of the error being thrown in
>> the field, it might be better to use ereport, to expose the message
>> for translation.
>
> I find the wording of the error messages a bit inappropriate. For
> example,
>
> list = PyList_New(length);
> + if (list == NULL)
> + elog(ERROR, "could not transform Python list to array");
>
> The error is not about the transforming, it's about creating a new list.
Well, what I tried to convery here was that the process of transforming
a Python list to a Postgres array failed. Which, by the way, is wrong
since this function transforms a Postgres array to a Python list...
After giving it some thought some of these elogs could be changed into
PLy_elogs (which is meant to propagate a Python error into Postgres) and
the others made into ereports.
I'll send updated patches this evening (CET).
Cheers,
Jan
From | Date | Subject | |
---|---|---|---|
Next Message | Sandro Santilli | 2012-02-21 17:42:42 | Re: Runtime SHAREDIR for testing CREATE EXTENSION |
Previous Message | David E. Wheeler | 2012-02-21 17:27:17 | Review: alternate psql file locations |