Re: Replication timeout units

From: "Kevin Grittner" <Kevin(dot)Grittner(at)wicourts(dot)gov>
To: "Peter Geoghegan" <peter(at)2ndquadrant(dot)com>, "Magnus Hagander" <magnus(at)hagander(dot)net>
Cc: "PostgreSQL-development" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Replication timeout units
Date: 2011-12-20 17:34:25
Message-ID: 4EF072C10200002500043E7A@gw.wicourts.gov
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Peter Geoghegan <peter(at)2ndquadrant(dot)com> wrote:
> Magnus Hagander <magnus(at)hagander(dot)net> wrote:
>> from postgresql.conf.sample:
>>
>> #replication_timeout = 60s # in milliseconds; 0 disables
>>
>> Seconds or milliseconds? I would suggest we just remove the "in
>> milliseconds", and instead say "timeout for replication
>> connections; 0 disables".
>
> +1 from me. That's very confusing.

Isn't it providing information on both the granularity and the
default unit if none is specified? Why is it more confusing here
than statement_timeout or any of the other places this pattern is
followed?

-1 from me on removing it *only* here.

-Kevin

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Kevin Grittner 2011-12-20 17:36:32 Re: Page Checksums
Previous Message Alvaro Herrera 2011-12-20 17:32:13 Re: Page Checksums