| From: | "Kevin Grittner" <Kevin(dot)Grittner(at)wicourts(dot)gov> |
|---|---|
| To: | "Heikki Linnakangas" <heikki(dot)linnakangas(at)enterprisedb(dot)com>, "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | "Andrew Dunstan" <andrew(at)dunslane(dot)net>, "Robert Haas" <robertmhaas(at)gmail(dot)com>, "Peter Eisentraut" <peter_e(at)gmx(dot)net>,<pgsql(at)j-davis(dot)com>, <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: new compiler warnings |
| Date: | 2011-10-19 16:10:18 |
| Message-ID: | 4E9EB01A0200002500042221@gw.wicourts.gov |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Unfortunately, the problem we're dealing with here is exactly that
> we can't write to stderr. So it's a bit hard to see what we can
> usefully do to report that we have a problem (short of crashing,
> which isn't a net improvement).
Are you sure that crashing on an assertion-enabled build *isn't* a
net improvement? It sounds like we're pretty convinced this is a
"can't happen" situation -- if it does happen either the API is not
honoring its contract or we've badly misinterpreted the contract.
It might allow us to catch bugs in development or testing (where
cassert builds are used) before they mangle production server logs.
I have a hard time understanding the argument against an Assert in
this case.
-Kevin
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2011-10-19 16:17:28 | Re: synchronized snapshots |
| Previous Message | Robert Haas | 2011-10-19 16:05:52 | Re: loss of transactions in streaming replication |