Re: binary patch problems

Why don't you set prepareThreshold to 0 for your test cases?
In this case parameter passing starts immediately for the
prepared statement, and ForceBinaryTransfers can be dropped.
Andras

> Thank you for the thorough analysis. Now we need to decide what to do
> with the ForceBinaryTransfers testing/debugging aid.
>
> It was originally added to ensure that while running the unit tests
> as much as possible of the code paths would exercise the binary > > >
> transfer
> code. Normally binary transfers would only be activated after few
> round-trips to the backend with the same prepared statement - which
> basically never happens in unit tests.
>
> We have at least three options:
> 1) drop the ForceBinaryTransfers
> - it has helpped debug the binary transfer to a working state
> - it is no longer that useful
> 2) leave it as is
> - just add the hack to the one failing test to make it not fail
> - it is still useful to run the test suite to verify functionality
> stays correct with binary transfers
> 3) fix it
> - less worries in the future and if some end user finds the
> undocumented feature they won't get bitten by it
>
> -Mikko
>