| From: | Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)commandprompt(dot)com> |
| Cc: | Alexander Korotkov <aekorotkov(at)gmail(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Compiler warnings with stringRelOpts (was WIP: Fast GiST index build) |
| Date: | 2011-08-09 10:25:23 |
| Message-ID: | 4E410B13.2060107@enterprisedb.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 08.08.2011 22:11, Alvaro Herrera wrote:
> Perhaps the easiest way to fix it is as you suggest, by declaring the
> struct to take a pointer rather than the value directly. Not sure how
> to make both cases work sanely; the add_string_reloption path will need
> updates.
Agreed, I propose the attached patch to do that. Are there any
extensions out there that use add_string_relopt(), that I could use for
testing?
--
Heikki Linnakangas
EnterpriseDB http://www.enterprisedb.com
| Attachment | Content-Type | Size |
|---|---|---|
| string-relopt-1.patch | text/x-diff | 2.8 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Shigeru Hanada | 2011-08-09 10:28:53 | Re: per-column FDW options, v5 |
| Previous Message | Shigeru Hanada | 2011-08-09 10:19:13 | Re: psql document fix about showing FDW options |