Skip site navigation (1) Skip section navigation (2)

Re: Seg-fault in format(text)

From: Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Dean Rasheed <dean(dot)a(dot)rasheed(at)gmail(dot)com>, pgsql-bugs(at)postgresql(dot)org
Subject: Re: Seg-fault in format(text)
Date: 2011-05-23 19:30:38
Message-ID: 4DDAB5DE.5000801@enterprisedb.com (view raw or flat)
Thread:
Lists: pgsql-bugs
On 23.05.2011 18:36, Tom Lane wrote:
> Heikki Linnakangas<heikki(dot)linnakangas(at)enterprisedb(dot)com>  writes:
>> It's a stretch that we'd ever support two billion arguments in any form,
>> but an explicit check for "arg<  0" would make me feel better.
>
> No objection here, especially since I've just determined that bug #6035
> is also some kind of unhandled-overflow problem...

Committed, using your suggested fix. I realized that switching to 
strtoul() wouldn't work without some further changes, because the format 
string is not null-terminated.

-- 
   Heikki Linnakangas
   EnterpriseDB   http://www.enterprisedb.com

In response to

pgsql-bugs by date

Next:From: Greg Sabino MullaneDate: 2011-05-23 20:59:32
Subject: 9.1 plperlu bug with null rows in trigger hash
Previous:From: Kevin GrittnerDate: 2011-05-23 19:17:36
Subject: Re: BUG #6028: age() function output contracts "months", but not any other units.

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group