| From: | Jan Urbański <wulczer(at)wulczer(dot)org> |
|---|---|
| To: | Peter Eisentraut <peter_e(at)gmx(dot)net> |
| Cc: | Hitoshi Harada <umi(dot)tanuki(at)gmail(dot)com>, Postgres - Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: pl/python quoting functions |
| Date: | 2011-02-23 10:26:50 |
| Message-ID: | 4D64E0EA.5080604@wulczer.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 22/02/11 22:48, Peter Eisentraut wrote:
> Committed this, with two changes: Changed some things around with the
> way const char * is propagated. Just casting it away is not nice. Also
> dropped the error tests in the _quote.sql regression test. This
> generates three different wordings of error messages from Python with
> 2.6, 3.1, and 3.2, which I don't care to maintain. Maybe one day we'll
> have a better solution for this.
Thanks.
One thing: you removed the conditional pfree from PLy_quote_ident, which
makes this function leak memory if the actual quoting took place, no? Is
that leak too small to worry about?
Cheers,
Jan
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Shigeru HANADA | 2011-02-23 11:30:05 | Re: PostgreSQL FDW update |
| Previous Message | rsmogura | 2011-02-23 09:00:00 | Re: Binary in/out for aclitem |