| From: | Guillaume Lelarge <guillaume(at)lelarge(dot)info> |
|---|---|
| To: | Julius Tuskenis <julius(at)nsoft(dot)lt> |
| Cc: | pgadmin-support(at)postgresql(dot)org |
| Subject: | Re: possible memory leak in Server Status window |
| Date: | 2011-02-12 08:23:52 |
| Message-ID: | 4D564398.4040006@lelarge.info |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgadmin-support |
Le 11/02/2011 11:42, Julius Tuskenis a écrit :
> Hello, Guillaume
>
> Please look at frmStatus::fillLogfileCombo(). Please note, that the set
> is defined and assigned, but then as it has not enough rows to be
> "interesting" the function returns 0 and exits. So "delete set;" is
> never called. Can this be the issue?
>
Yes, it's definitely a memory leak. As I don't have the adminpack
installed, I had no way to find this (other than reading the complete
frmStatus code).
Anyway, I pushed a fix for this.
I know Peter and Dave talked about some stuff I actually didn't
understand, but it seems it would take some time to do. So, I prefer
having this simple and effective fix right now :)
Thanks, Julius, for reporting the leak and caring enough to actually
read the code :)
--
Guillaume
http://www.postgresql.fr
http://dalibo.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Vladimir Kokovic | 2011-02-12 08:50:23 | Enpty field, grid editor, NOT NULL |
| Previous Message | Peter Geoghegan | 2011-02-11 15:24:35 | Re: possible memory leak in Server Status window |