Re: pg_dump --split patch

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Joel Jacobson <joel(at)gluefinance(dot)com>
Cc: Gurjeet Singh <singh(dot)gurjeet(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Subject: Re: pg_dump --split patch
Date: 2010-12-28 21:57:34
Message-ID: 4D1A5D4E.8040103@dunslane.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 12/28/2010 04:44 PM, Joel Jacobson wrote:
>
>
>
>
>> The problem I see with suffixing a sequence id to the objects with
>> name collision is that one day the dump may name myfunc(int) as
>> myfunc.sql and after an overloaded version is created, say
>> myfunc(char, int), then the same myfunc(int) may be dumped in
>> myfunc-2.sql, which again is non-deterministic.
>
> I agree, good point!
> Perhaps abbreviations are to prefer, e.g., myfunc_i, myfunc_i_c, etc
> to reduce the need of truncating filenames.
>
>
>

I think that's just horrible. Does the i stand for integer or inet? And
it will get *really* ugly for type names with spaces in them ...

cheers

andrew

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Kevin Grittner 2010-12-28 22:10:59 SSI SLRU strategy choices
Previous Message Karl Lehenbauer 2010-12-28 21:52:44 Re: Patch to add table function support to PL/Tcl (Todo item)