| From: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
|---|---|
| To: | Magnus Hagander <magnus(at)hagander(dot)net> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: MingW and MiniDumps |
| Date: | 2010-12-26 00:10:56 |
| Message-ID: | 4D168810.4080506@dunslane.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 12/20/2010 01:25 PM, Magnus Hagander wrote:
> On Mon, Dec 20, 2010 at 19:24, Tom Lane<tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> Andrew Dunstan<andrew(at)dunslane(dot)net> writes:
>>> Maybe. I have no idea where narwhal got its version of dbghelp.h. I
>>> copied the file from the SDK directory to mingw's include directory and
>>> the build then ran perfectly. I think therefore the right thing is to
>>> have a configure test for the file and for MINIDUMP_TYPE on win32, and
>>> only build in crashdump if it passes those tests.
> +1.
>
>
Suggested patch attached.
cheers
andrew
| Attachment | Content-Type | Size |
|---|---|---|
| crashdump.patch | text/x-patch | 6.1 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Gurjeet Singh | 2010-12-26 03:13:23 | Re: WIP patch for parallel pg_dump |
| Previous Message | Tom Lane | 2010-12-25 20:39:10 | Re: pgsql: Add foreign data wrapper error code values for SQL/MED. |