| From: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
|---|---|
| To: | Itagaki Takahiro <itagaki(dot)takahiro(at)gmail(dot)com> |
| Cc: | Shigeru HANADA <hanada(at)metrosystems(dot)co(dot)jp>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: SQL/MED - file_fdw |
| Date: | 2010-12-10 20:30:55 |
| Message-ID: | 4D028DFF.2060401@dunslane.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 12/04/2010 11:11 PM, Itagaki Takahiro wrote:
> On Sun, Dec 5, 2010 at 07:24, Andrew Dunstan<andrew(at)dunslane(dot)net> wrote:
>> Looking at file_parser.c, it seems to be largely taken from copy.c. Wouldn't
>> it be better to call those functions, or refactor them so they are callable
>> if necessary?
> We could export private functions and structs in copy.c,
> though details of the implementation should be kept in copy.c.
>
> How about splitting the file_fdw patch into two pieces?
> One exports the copy functions from the core, and another
> implements file_fdw using the infrastructure.
>
Who is actually going to do this split?
cheers
andrew
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2010-12-10 20:33:37 | Re: ALTER EXTENSION ... UPGRADE; |
| Previous Message | Tom Lane | 2010-12-10 20:26:41 | Re: create tablespace fails silently, or succeeds improperly |