| From: | Guillaume Lelarge <guillaume(at)lelarge(dot)info> |
|---|---|
| To: | pg(at)kuhnsteffen(dot)de |
| Cc: | pgadmin-hackers(at)postgresql(dot)org |
| Subject: | Re: Save Query in frmEditGrid |
| Date: | 2010-09-14 19:35:03 |
| Message-ID: | 4C8FCE67.2030009@lelarge.info |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgadmin-hackers |
Le 14/09/2010 13:09, Steffen Kuhn a écrit :
> Hi Guillaume,
>
> checking for changed values is what I tried to, but my place was
> sqlGridEditor::EndEdit because this is already checked there.
Oh, yeah, I didn't see that. You're right.
> But checking here, may be also in OnEditorHidden can be dangerous I think, because of
> there might be previous changes that might be lost by just disableing 'Save' if one cell has not been changed.
> This may also happen by doing CancelChange with 'ESC'.
> I think there will be no other way as comparing the whole row.
>
> I would prefer you fixing this, it's to hot for me right now.
>
This patch should do it, can you try and test it, please?
Thanks.
--
Guillaume
http://www.postgresql.fr
http://dalibo.com
| Attachment | Content-Type | Size |
|---|---|---|
| closefrmeditgrid.patch | text/x-diff | 727 bytes |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Guillaume Lelarge | 2010-09-14 21:04:01 | Re: Fwd: pgAdmin 1.12 rc1 editing issue frmEditGrid |
| Previous Message | Steffen Kuhn | 2010-09-14 11:09:36 | Re: Save Query in frmEditGrid |