| From: | Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com> |
|---|---|
| To: | Jeff Davis <pgsql(at)j-davis(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers(at)postgresql(dot)org, Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, Magnus Hagander <magnus(at)hagander(dot)net> |
| Subject: | Re: Interruptible sleeps (was Re: CommitFest 2009-07: Yay, Kevin! Thanks, reviewers!) |
| Date: | 2010-09-13 18:01:49 |
| Message-ID: | 4C8E670D.8050405@enterprisedb.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 13/09/10 20:43, Jeff Davis wrote:
> On Mon, 2010-09-13 at 09:10 +0300, Heikki Linnakangas wrote:
>>> but we should be consistent and document that:
>>> (a) it shouldn't happen
>>> (b) that it's just a sanity check and we're ignoring the race
>>
>> Would this be sufficient?
>>
>> --- a/src/backend/port/unix_latch.c
>> +++ b/src/backend/port/unix_latch.c
>> @@ -156,6 +156,7 @@ OwnLatch(volatile Latch *latch)
>> if (selfpipe_readfd == -1)
>> initSelfPipe();
>>
>> + /* sanity check */
>> if (latch->owner_pid != 0)
>> elog(ERROR, "latch already owned");
>> latch->owner_pid = MyProcPid;
>>
>> Or you want to suggest something better?
>
> Perfect. I was just slightly confused reading it the first time, and I
> think that would have cleared it up.
Ok, added that.
--
Heikki Linnakangas
EnterpriseDB http://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2010-09-13 18:08:07 | Re: Policy decisions and cosmetic issues remaining for the git conversion |
| Previous Message | Jeff Davis | 2010-09-13 17:43:16 | Re: Interruptible sleeps (was Re: CommitFest 2009-07: Yay, Kevin! Thanks, reviewers!) |