Re: Initial review of xslt with no limits patch

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Mike Fowler <mike(at)mlfowler(dot)com>
Cc: Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Initial review of xslt with no limits patch
Date: 2010-08-06 03:37:05
Message-ID: 4C5B8361.5070400@dunslane.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 08/05/2010 06:56 PM, Mike Fowler wrote:
>
> SELECT
> xslt_process('<employee><name>cim</name><age>30</age><pay>400</pay></employee>'::text,
> $$<xsl:stylesheet xmlns:xsl="http://www.w3.org/1999/XSL/Transform"
> version="1.0">
> <xsl:output method="xml" omit-xml-declaration="yes" indent="yes"/>
>
[snip]
> </xsl:stylesheet>$$::text, 'n1=v1,n2=v2,n3=v3,n4=v4,n5=v5'::text)
>
>

I haven't been paying attention to this, so sorry if this has been
discussed before, but it just caught my eye. Why are we passing these
params as a comma-separated list rather than as an array or as a
variadic list of params? This looks rather ugly. What if you want to
have a param that includes a comma?

cheers

andrew

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message pgsql-hackers 2010-08-06 03:44:07 pgsql-hackers@news.hub.org 81% OFF on Pfizer!
Previous Message Pavel Stehule 2010-08-06 03:11:04 Re: Initial review of xslt with no limits patch