Re: antisocial things you can do in git (but not CVS)

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Jonathan Corbet <corbet(at)lwn(dot)net>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: antisocial things you can do in git (but not CVS)
Date: 2010-07-21 19:11:41
Message-ID: 4C47466D.4060701@dunslane.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Jonathan Corbet wrote:
>> 3. Merge commits. I believe that we have consensus that commits
>> should always be done as a "squash", so that the history of all of our
>> branches is linear. But it seems to me that someone could
>> accidentally push a merge commit, either because they forgot to squash
>> locally, or because of a conflict between their local git repo's
>> master branch and origin/master. Can we forbid this?
>>
>
> That seems like a terrible idea to me - why would you destroy history?
> Obviously I've missed a discussion here. But, the first time somebody
> wants to use bisect to pinpoint a regression-causing patch, you'll wish you
> had that information there.
>
>

We have a clear idea of what should be part of the public history
contained in the authoritative repo and what should be history that is
private to the developer/tester/committer. We don't want to pollute the
former with the latter. The level of granularity of our current CVS
commits seems to us to be about right.

So when a committer pushes a patch it should add one fast-forward commit
to the tree. We want to be able to bisect between these commit objects,
but not between all the work product commits that led up to them. Of
course, developers, committers and testers can keep what they like
privately - we're only talking about what should go in the authoritative
repo.

cheers

andrew

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Eisentraut 2010-07-21 19:18:58 need more ALTER TABLE guards for typed tables
Previous Message Magnus Hagander 2010-07-21 19:11:33 Re: documentation for committing with git