Re: [COMMITTERS] pgsql: pgindent run for 9.0, second run

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Magnus Hagander <magnus(at)hagander(dot)net>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, Kevin Grittner <Kevin(dot)Grittner(at)wicourts(dot)gov>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [COMMITTERS] pgsql: pgindent run for 9.0, second run
Date: 2010-07-20 16:42:25
Message-ID: 4C45D1F1.3060607@dunslane.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

Magnus Hagander wrote:
> On Tue, Jul 20, 2010 at 18:13, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
>
>> On Tue, Jul 20, 2010 at 12:01 PM, Kevin Grittner
>> <Kevin(dot)Grittner(at)wicourts(dot)gov> wrote:
>>
>>> Andrew Dunstan <andrew(at)dunslane(dot)net> wrote:
>>>
>>>
>>>> I despaired of this repo being anything like reliable months ago.
>>>> AFAIK it is using a known to be broken version of fromcvs.
>>>>
>>> Could we have it pull (using git) from the repo you have working
>>> correctly? (Or would that be too Rube Goldbergesque?)
>>>
>> It would result in a massive merge commit and the duplication of the
>> entire history. The correct solution is probably to (a) install
>> Andrew's fixed version of the import tool on the server and (b) rewind
>> the history on the server so it reimports all the subsequent commits.
>> Sometimes doing only (b) is sufficient to correct the problem, since
>> the tool seems rather sensitive to ephemeral states of the
>> respository.
>>
>> Unfortunately, (a) has not happened. Magnus seems to feel that Andrew
>> has not provided sufficient details about which version he should be
>> running and whether it will likely break anything, and I gather that
>> Andrew feels otherwise. Figuring out who is right and who is wrong
>> and what to do about it is above my pay grade, but it would be really
>> nice if someone could get this straightened out.
>>
>
> Meh, who cares who's right or wrong :-)
>
> My main point is I am unsure if this may have any adverse effects, and
> I haven't had the time to investigate if it doesor not. Previously
> we've just applied a manual correction patch to bring the branch tip
> up to the correct state, which is supposedly good enough for the users
> of the git server. In which case, someone just needs to proide said
> patch :-)
>
>

Given that the repo's remaining lifetime is measured in weeks, that
seems reasonable.

cheers

andrew

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Bruce Momjian 2010-07-20 18:14:16 pgsql: Properly replay CREATE TABLESPACE during crash recovery by
Previous Message Magnus Hagander 2010-07-20 16:34:25 Re: [COMMITTERS] pgsql: pgindent run for 9.0, second run

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2010-07-20 17:04:12 managing git disk space usage
Previous Message Magnus Hagander 2010-07-20 16:34:25 Re: [COMMITTERS] pgsql: pgindent run for 9.0, second run