| From: | Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, Kris Jurka <books(at)ejurka(dot)com>, Rushabh Lathia <rushabh(dot)lathia(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Rushabh Lathia <rushabh(dot)lathia(at)enterprisedb(dot)com> |
| Subject: | Re: [BUGS] Server crash while trying to read expression using pg_get_expr() |
| Date: | 2010-06-21 23:50:39 |
| Message-ID: | 4C1FFACF.7030101@enterprisedb.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs pgsql-hackers |
On 15/06/10 10:31, Heikki Linnakangas wrote:
> You could avoid changing the meaning of fn_expr by putting the check in
> the parse analysis phase, into transformFuncCall(). That would feel
> safer at least for back-branches.
Here's a patch using that approach.
I grepped through PostgreSQL and pgadmin source code to find the system
columns where valid node-strings are stored:
pg_index.indexprs
pg_index.indprep
pg_attrdef.adbin
pg_proc.proargdefaults
pg_constraint.conbin
Am I missing anything?
--
Heikki Linnakangas
EnterpriseDB http://www.enterprisedb.com
| Attachment | Content-Type | Size |
|---|---|---|
| restrict-pg_get_expr-1.patch | text/x-diff | 3.3 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2010-06-22 04:28:01 | Re: Bug in PL/pgSQL FOR cursor variant |
| Previous Message | Heikki Linnakangas | 2010-06-21 22:49:57 | Re: Bug in PL/pgSQL FOR cursor variant |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | gabrielle | 2010-06-21 23:51:49 | Re: Explicit psqlrc |
| Previous Message | Simon Riggs | 2010-06-21 22:13:42 | Re: Cannot cancel the change of a tablespace |