Re: Re: [COMMITTERS] pgsql: Check compulsory parameters in recovery.conf in standby_mode, per

From: Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com>
To: Simon Riggs <simon(at)2ndQuadrant(dot)com>
Cc: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Re: [COMMITTERS] pgsql: Check compulsory parameters in recovery.conf in standby_mode, per
Date: 2010-04-06 09:38:04
Message-ID: 4BBB00FC.1050103@enterprisedb.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

Simon Riggs wrote:
> On Tue, 2010-04-06 at 10:19 +0300, Heikki Linnakangas wrote:
>> Fujii Masao wrote:
>>> On Tue, Apr 6, 2010 at 3:29 AM, Simon Riggs <simon(at)2ndquadrant(dot)com> wrote:
>>>> I was also surprised to note that the Startup process is not signaled by
>>>> WALReceiver when new WAL is received, so it will continue sleeping even
>>>> though it has work to do.
>>> I don't think this is so useful in 9.0 since synchronous replication
>>> (i.e., transaction commit wait for WAL to be replayed by the standby)
>>> is not supported.
>> Well, it would still be useful, as it would shorten the delay. But yeah,
>> there's a delay in asynchronous replication anyway, so we decided to
>> keep it simple and just poll. It's not ideal and definitely needs to be
>> revisited for synchronous mode in the future. Same for walsenders.
>
> A signal seems fairly straightforward to me, the archiver did this in
> 8.0 and it was not considered complex then. Quite why it would be
> complex here is not clear.

The other side of the problem is that walsender polls too. Eliminating
the delay from walreceiver doesn't buy you much unless you eliminate the
delay from the walsender too. And things get complicated there. Do you
signal the walsenders at every commit? That would be a lot of volume,
and adds more work for every normal transaction in the primary. Maybe
not much, but it would be one more thing to worry about and test.

> I'm not happy that it waits, nor that the wait is non-tunable. I would
> like to see a new parameter added for this.

I wanted to keep it simple for users, but feel free to add a parameter
if you feel it must be configurable.

--
Heikki Linnakangas
EnterpriseDB http://www.enterprisedb.com

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Simon Riggs 2010-04-06 10:04:31 Re: Re: [COMMITTERS] pgsql: Check compulsory parameters in recovery.conf in standby_mode, per
Previous Message Simon Riggs 2010-04-06 07:48:47 Re: Re: [COMMITTERS] pgsql: Check compulsory parameters in recovery.conf in standby_mode, per

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Eisentraut 2010-04-06 09:44:25 Re: message clarifications
Previous Message Takahiro Itagaki 2010-04-06 09:32:37 Re: SELECT constant; takes 15x longer on 9.0?