Re: Query tool layout issues

From: Guillaume Lelarge <guillaume(at)lelarge(dot)info>
To: Dave Page <dpage(at)pgadmin(dot)org>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: Query tool layout issues
Date: 2010-03-03 22:03:05
Message-ID: 4B8EDC99.7030001@lelarge.info
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Le 03/03/2010 13:25, Dave Page a écrit :
> On Tue, Mar 2, 2010 at 10:52 PM, Guillaume Lelarge
> <guillaume(at)lelarge(dot)info> wrote:
>> The color used is #dddddd. Probably I should add the ability to
>> customize it, as we can already customize much of the background and
>> foreground colors.
>
> Yeah, that works. I agree it should be customisable, seeing as
> everything else is.
>

See patch attached (margin.patch).

>>> - The buttons to the right of the recent queries combo are not lined up with it.
>>>
>>
>> Can you check query.patch? Works OK for me on GTK, and is less ugly on
>> Mac OS X. Is it good enough for you?
>
> Yup, that looks better. Couple of thoughts though...
>
> - Only add a query to the list is it executes without an error,
> otherwise it will get spammed with non-functional queries and typos.
> - You can probably remove the 'Current' from 'Delete Current' and save
> some space. I think current is implied by the fact that the other says
> 'all'.
>

Done too. See miscquery.patch.

--
Guillaume.
http://www.postgresqlfr.org
http://dalibo.com

Attachment Content-Type Size
margin.patch text/x-patch 7.3 KB
miscquery.patch text/x-patch 1.2 KB

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message svn 2010-03-03 22:29:19 SVN Commit by guillaume: r8200 - trunk/pgadmin3/pgadmin/ctl
Previous Message Guillaume Lelarge 2010-03-03 21:04:48 Re: SQL Syntax Highlight Configuration