Re: pgsql: Rethink the way walreceiver is linked into the backend. Instead

From: Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com>
To: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
Cc: pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Rethink the way walreceiver is linked into the backend. Instead
Date: 2010-01-20 11:59:55
Message-ID: 4B56F03B.1020200@enterprisedb.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Fujii Masao wrote:
> And I found the small bug. Could you fix it?
>
> src/backend/replication/libpqwalreceiver/libpqwalreceiver.c
>> _PG_init(void)
>> {
>> /* Tell walreceiver how to reach us */
>> if (walrcv_connect != NULL || walrcv_receive != NULL || walrcv_disconnect)
>> elog(ERROR, "libpqwalreceiver already loaded");
>
> In the above branch on condition, the "walrcv_disconnect" should be compared
> with "NULL".

Thanks. "walrcv_disconnect" has the same effect as "walrcv_disconnect !=
NULL", but fixed for the sake of consistency.

--
Heikki Linnakangas
EnterpriseDB http://www.enterprisedb.com

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Heikki Linnakangas 2010-01-20 18:54:27 pgsql: Now that much of walreceiver has been pulled back into the
Previous Message Heikki Linnakangas 2010-01-20 11:58:44 pgsql: Add missing "!= NULL", for the sake of consistency.