From: | Guillaume Lelarge <guillaume(at)lelarge(dot)info> |
---|---|
To: | Dave Page <dpage(at)pgadmin(dot)org> |
Cc: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
Subject: | Re: SVN Commit by guillaume: r8145 - in trunk/pgadmin3: . pgadmin/db pgadmin/frm |
Date: | 2010-01-03 10:11:49 |
Message-ID: | 4B406D65.3070301@lelarge.info |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
Le 03/01/2010 10:55, Dave Page a écrit :
> On Sat, Jan 2, 2010 at 9:57 PM, Guillaume Lelarge
> <guillaume(at)lelarge(dot)info> wrote:
>
>> OK. Here is a new patch which calls PQconninfoParse and acts according
>> to its return code. It also removes part of the old patch.
>>
>> Is it better?
>
> Certainly looks more as I imagined. There is a little inconsistency though:
>
> + wxString applicationname = wxT("pgAdmin (Query Tool)");
>
> ...
>
> + wxString applicationname = wxT("pgAdmin - Query Tool");
>
Will fix this.
> Also, doesn't the debugger falback to the libc encoding as the main
> connection class does?
>
It didn't have the fallback libc encoding code before I began to work on
this, so I didn't add it. But I can add that pretty easily.
--
Guillaume.
http://www.postgresqlfr.org
http://dalibo.com
From | Date | Subject | |
---|---|---|---|
Next Message | Dave Page | 2010-01-03 10:15:41 | Re: SVN Commit by guillaume: r8145 - in trunk/pgadmin3: . pgadmin/db pgadmin/frm |
Previous Message | Dave Page | 2010-01-03 09:55:05 | Re: SVN Commit by guillaume: r8145 - in trunk/pgadmin3: . pgadmin/db pgadmin/frm |