Re: Change to config.pl processing in the msvc build environment

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Peter Eisentraut <peter_e(at)gmx(dot)net>
Cc: Magnus Hagander <magnus(at)hagander(dot)net>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Change to config.pl processing in the msvc build environment
Date: 2010-01-03 04:13:09
Message-ID: 4B401955.3040400@dunslane.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Peter Eisentraut wrote:
> On fre, 2010-01-01 at 16:32 +0100, Magnus Hagander wrote:
>
>> I therefor propose that we rename this file to "config.pl.default",
>> and change the scripts to first load config.pl.default, and then load
>> config.pl if it exists.
>>
>
> I'd keep the naming so that the extension .pl is preserved. Helps
> editors and such.
>
>

Right ... let's call it "default_config.pl" or some such. Otherwise it
looks sane enough. I don't think the "parens on trailing conditions"
issue is anything other than just a matter of taste. I often use them
because I've occasionally been caught by not doing so.

cheers

andrew

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Hitoshi Harada 2010-01-03 04:19:55 Re: PATCH: Add hstore_to_json()
Previous Message Hitoshi Harada 2010-01-03 03:40:54 Re: IntArray in c.h