| From: | Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com> |
|---|---|
| To: | Simon Riggs <simon(at)2ndQuadrant(dot)com> |
| Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Hot Standby remaining issues |
| Date: | 2009-11-30 10:08:37 |
| Message-ID: | 4B1399A5.7080607@enterprisedb.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Simon Riggs wrote:
> @@ -654,10 +656,13 @@ LockAcquire(const LOCKTAG *locktag,
> elog(PANIC, "lock table corrupted");
> }
> LWLockRelease(partitionLock);
> - ereport(ERROR,
> - (errcode(ERRCODE_OUT_OF_MEMORY),
> - errmsg("out of shared memory"),
> - errhint("You might need to increase max_locks_per_transaction.")));
> + if (reportLockTableError)
> + ereport(ERROR,
> + (errcode(ERRCODE_OUT_OF_MEMORY),
> + errmsg("out of shared memory"),
> + errhint("You might need to increase max_locks_per_transaction.")));
> + else
> + return LOCKACQUIRE_NOT_AVAIL;
> }
> locallock->proclock = proclock;
>
That seems dangerous when dontWait==false.
--
Heikki Linnakangas
EnterpriseDB http://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andrew Gierth | 2009-11-30 10:34:08 | Re: Aggregate ORDER BY patch |
| Previous Message | Andres Freund | 2009-11-30 09:37:43 | Re: draft RFC: concept for partial, wal-based replication |