| From: | Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com> |
|---|---|
| To: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
| Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Compiler warning |
| Date: | 2009-05-20 08:48:34 |
| Message-ID: | 4A13C3E2.8000200@enterprisedb.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Fujii Masao wrote:
> I encountered the following compiler warning in 8.4dev.
> Attached is the patch to fix this problem. Is this worth committing?
>
> ------------------
> tablecmds.c: In function 'DropErrorMsgWrongType':
> tablecmds.c:606: warning: format not a string literal and no format arguments
> ------------------
Hmm, it is a false alarm, but would be nice to have a warning-free
build. I don't see that warning here on gcc 4.3.3 by default, but I do
when I set -Wformat-security. I presume you had that set as well.
Applied.
--
Heikki Linnakangas
EnterpriseDB http://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Ron Mayer | 2009-05-20 09:41:10 | Re: INTERVAL data type and libpq - what format? |
| Previous Message | Andres Freund | 2009-05-20 08:23:34 | Re: Multiple sorts in a query |