Re: Fast BigDecimal

Kris Jurka wrote:
>
>
> On Sat, 18 Apr 2009, Kris Jurka wrote:
>
>> On Thu, 16 Apr 2009, Heikki Linnakangas wrote:
>>
>>> Here's another patch I put together while trying to improve
>>> performance for the customer that bumped into the repeated Describe
>>> thing yesterday. It speeds up ResultSet.getBigDecimal() with the same
>>> fastpath implementation we have for getInt and getLong.
>>
>> To maintain the same behavior as the current code, you need to handle
>> the period more carefully. You must ensure that there is only one and
>> that there's at least one other number. Consider the case of SELECT
>> '.' OR SELECT '1.......'.
>>
>
> For some reason I thought this would be tricky. We just need to track
> the total number for periods seen and error out if > 1 or equal to the
> total number of characters. I've done that and committed it.

Thanks. One more thing: this accepts "-.", which the normal version
doesn't. Patch attached.

--
Heikki Linnakangas
EnterpriseDB http://www.enterprisedb.com