Re: [COMMITTERS] pgsql: Tell gettext which codeset to use by calling

From: Teodor Sigaev <teodor(at)sigaev(dot)ru>
To: Heikki Linnakangas <heikki(at)postgresql(dot)org>
Cc: Pgsql Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [COMMITTERS] pgsql: Tell gettext which codeset to use by calling
Date: 2009-04-08 12:56:11
Message-ID: 49DC9EEB.5070509@sigaev.ru
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

> Log Message:
> -----------
> Tell gettext which codeset to use by calling bind_textdomain_codeset(). We
> already did that on Windows, but it's needed on other platforms too when
> LC_CTYPE=C. With other locales, we enforce (or trust) that the codeset of
> the locale matches the server encoding so we don't need to bind it
> explicitly. It should do no harm in that case either, but I don't have
> full faith in the PG encoding -> OS codeset mapping table yet. Per recent
> discussion on pgsql-hackers.

% CFLAGS=-O0 ./configure --enable-depend --enable-cassert --enable-debug
--disable-coverage
% gmake
.....
utils/init/postinit.o(.text+0x697): In function `CheckMyDatabase':
/spool/home/teodor/pgsql/src/backend/utils/init/postinit.c:269: undefined
reference to `textdomain'
gmake[2]: *** [postgres] Ошибка 1
gmake[2]: Leaving directory `/spool/home/teodor/pgsql/src/backend'
gmake[1]: *** [all] Ошибка 2
gmake[1]: Leaving directory `/spool/home/teodor/pgsql/src'
gmake: *** [all] Ошибка 2

May be call of pg_bind_textdomain_codeset(textdomain(NULL)); should be wrapped
by ENABLE_NLS?

--
Teodor Sigaev E-mail: teodor(at)sigaev(dot)ru
WWW: http://www.sigaev.ru/

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Heikki Linnakangas 2009-04-08 13:08:09 pgsql: Oops, mustn't call textdomain() when compiling without
Previous Message Heikki Linnakangas 2009-04-08 10:36:01 Re: Re: [COMMITTERS] pgsql: Explicitly bind gettext to the correct encoding on Windows.

Browse pgsql-hackers by date

  From Date Subject
Next Message Heikki Linnakangas 2009-04-08 13:08:39 Re: [COMMITTERS] pgsql: Tell gettext which codeset to use by calling
Previous Message Sam Mason 2009-04-08 11:31:02 Re: NaN support in NUMERIC data type