| From: | Andrew Chernow <ac(at)esilo(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Bruce Momjian <bruce(at)momjian(dot)us>, Robert Haas <robertmhaas(at)gmail(dot)com>, Merlin Moncure <mmoncure(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: PQinitSSL broken in some use casesf |
| Date: | 2009-03-28 18:29:25 |
| Message-ID: | 49CE6C85.9040806@esilo.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Tom Lane wrote:
>
> I personally would be happy with the two-argument function solution.
>
The patch I submitted pretty much does this, except it uses a flags argument
instead of 2 fixed arguments. It can be easily changed to support the 2
argument idea:
1. Change prototype to: void PQinitSecure(int ssl, int crypto);
- previous return value can go away, new version can be void.
2. Remove PG_SECURE_SSL, PG_SECURE_CRYPTO from libpq-fe.h
3. Modify wrapping code in PQinitSSL to use new prototype.
- either pass 0,0 or 1,1, to PQinitSecure.
Outside of that, the patch goes unchanged.
--
Andrew Chernow
eSilo, LLC
every bit counts
http://www.esilo.com/
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Dave Page | 2009-03-28 18:33:47 | Re: 8.4 open items list |
| Previous Message | Tom Lane | 2009-03-28 18:09:21 | Re: tuplestore API problem |