Re: Some notes on pgAdmin

From: Guillaume Lelarge <guillaume(at)lelarge(dot)info>
To: Dave Page <dpage(at)pgadmin(dot)org>
Cc: Chuck McDevitt <cmcdevitt(at)greenplum(dot)com>, pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: Some notes on pgAdmin
Date: 2009-03-09 16:21:09
Message-ID: 49B541F5.1090906@lelarge.info
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Dave Page a écrit :
> On Sat, Feb 28, 2009 at 12:19 AM, Chuck McDevitt
> <cmcdevitt(at)greenplum(dot)com> wrote:
>> 1. Going through the code, I noticed that quite a few files use 4
>> spaces for indent on most of their lines, but have some lines using tab
>> characters. Usually it’s newer patches that introduced the tabs, but not
>> always. Mixing both kinds of indents is confusing.
>
> Yeah - we generally use 4 spaces, but tabs keep creeping in. I'm
> beginning to this we should use tabs instead, and see if we can't run
> something akin to pgindent over the code to clean it up nicely.
>
> What do people prefer - tabs or spaces?
>

Spaces seem better to me. But I wouldn't say I didn't put some tabs in
some files.

--
Guillaume.
http://www.postgresqlfr.org
http://dalibo.com

In response to

Browse pgadmin-hackers by date

  From Date Subject
Next Message svn 2009-03-09 17:08:57 SVN Commit by dpage: r7655 - in trunk/pgadmin3/pkg/win32: . src
Previous Message Dave Page 2009-03-09 16:11:00 Re: help for "quick search" / bug ? / ODBC plugin?