Re: Server Status window work

Guillaume Lelarge a écrit :
> Dave Page a écrit :
>> OK, fresh message with test results from the v13 patch :-)
>>
>> - terminate_backend.xpm is missing
>>
>
> Sorry about this. I'll send a new patch with this file.
>

Done.

>> - The default perspectives are still not good (at least on Windows).
>
> I didn't change it on Mac because I couldn't find a way to get the
> recorded preference.
>

Your method works great.

>> The toolbar is still sized so that the refresh combo box doesn't fit -
>> actually I'm not sure if this isn't another bug. Using the 'Default
>> View' option didn't help. It got fixed when I removed all the existing
>> registry settings for frmStatus and opened the Window again. Related
>> to that, if I un-dock a pane on Windows, currently the default size is
>> approx 1cm^2, similar to the problem I noticed on the Mac :-)
>>
>
> I always do my tests without old settings. Strange that the Default View
> did nothing.
>

Fixed.

>> - Can you please add dividers before the logfile combo box, and after
>> the rotate button to separate them from the other controls.
>>
>
> No problem.
>

Done.

>> - We need an event that can capture changes to the active pane
>> properly (as you noted). I'll look at that in a minute and see what I
>> can figure out. The current behaviour is too unpredictable.
>>

Fixed with your "truly horrible kludge". The wxTimer is set to half a
second, and it doesn't enough on Mac. Maybe 400ms would be better.

>> With regard to the perspective issues, here's how I normally deal with them:
>>
>> - Delete all existing stored settings, and open the dialog.
>>
>> - Size each pane appropriately, in the default-sized window.
>>
>> - Undock each pane in turn, and size it appropriately. Redock when
>> sized. You can undock and redock again to check that the correct size
>> is retained
>>
>> - Close the window, and grab the perspective setting from the
>> registry/config file, and copy to the source file.
>>
>> - Repeat on each of the three platforms.
>>
>
> I already did that, but without the "undock" step. I'll do it again
> before sending v14.
>

Done. I finally understood what's in the perspective. I finally found
editing the string manually was a better way.

I still didn't change the listview with a textbox for the Logfile pane.
It's a big work and I would prefer to finish this one before doing the
change.

See the attached patch.

--
Guillaume.
http://www.postgresqlfr.org
http://dalibo.com