| From: | Andrew Chernow <ac(at)esilo(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, Merlin Moncure <mmoncure(at)gmail(dot)com>, Bruce Momjian <bruce(at)momjian(dot)us>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: PQinitSSL broken in some use casesf |
| Date: | 2009-02-19 16:36:20 |
| Message-ID: | 499D8A84.8050807@esilo.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Andrew Chernow wrote:
> Andrew Chernow wrote:
>>
>> > Maybe better, have it return a zero/nonzero error code; where one
>> of the
>> > possibilities for failure is "you passed a bit I didn't understand".
>>
>> Why not just return those bit(s) instead of an arbitrary code? How
>> about:
>>
>> -1 = error (if it ever does anything that can fail)
>> 0 = success (all bits known)
>> >0 = unknown bits (remaining known bits *have* been set)
>>
>
> I attached a patch that implements the above, using PQinitSecure as the
> function name.
>
>
Fixed a bug in the patch. I forgot to make PQinitSSL update the new
pg_initcryptolib flag. My fix was to make PQinitSSL proxy to PQinitSecure.
--
Andrew Chernow
eSilo, LLC
every bit counts
http://www.esilo.com/
| Attachment | Content-Type | Size |
|---|---|---|
| initsecure.patch | text/plain | 9.3 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Lawrence, Ramon | 2009-02-19 16:37:05 | Re: Proposed Patch to Improve Performance of Multi-BatchHash Join for Skewed Data Sets |
| Previous Message | Tom Lane | 2009-02-19 16:25:50 | Re: autovacuum not honoring pg_autovacuum in 8.3.5? |