| From: | Peter Eisentraut <peter_e(at)gmx(dot)net> |
|---|---|
| To: | Magnus Hagander <magnus(at)hagander(dot)net> |
| Cc: | Hiroshi Inoue <inoue(at)tpf(dot)co(dot)jp>, Bruce Momjian <bruce(at)momjian(dot)us>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PG Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Re: [COMMITTERS] pgsql: Explicitly bind gettext() to the UTF8 locale when in use. |
| Date: | 2009-01-21 12:54:54 |
| Message-ID: | 49771B1E.6040109@gmx.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
Magnus Hagander wrote:
> However, one question: The comment currently says it's harmless to do
> this on non-windows platforms. Does this still hold true?
Yes, the non-WIN32 code path appears to be the same, still. But the
ifdef WIN32 part we don't want, because that presumes something about
the spelling of encoding names in the local iconv library.
> If we do keep the thing win32 only, I think we should just wrap the
> whole thing in #ifdef WIN32 and no longer do the codeset stuff at all on
> Unix - that'll make for cleaner code.
Yes, that would be much better.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Magnus Hagander | 2009-01-21 13:34:30 | Re: Re: [COMMITTERS] pgsql: Explicitly bind gettext() to the UTF8 locale when in use. |
| Previous Message | Magnus Hagander | 2009-01-21 12:45:06 | pgsql: Remove stray ' character at end of line. |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andrew Dunstan | 2009-01-21 13:00:05 | Re: about truncate |
| Previous Message | Alvaro Herrera | 2009-01-21 12:52:09 | Re: reducing statistics write overhead |