Re: Server Status window work

Dave Page a écrit :
> On Wed, Jan 7, 2009 at 10:08 PM, Guillaume Lelarge
> <guillaume(at)lelarge(dot)info> wrote:
>> I suppose the cool functionality is wxAUI_NB_TAB_SPLIT :)
>
> Yep.
>
>> Actually, I find this great. It works nice on Mac OS X, but I disabled
>> it on v2 because it crashes the linux build. Perhaps I did something
>> wrong but even the auidemo sample from wxGTK crashes.
>>
>> (re-enables the "cool functionality", so crashes a lot on my laptop)
>
> Oh, rats. I hate getting my hands dirty on wxGTK :-(
>

I found this bug report : http://trac.wxwidgets.org/ticket/4841

My issue seems related to this.

>> You mean, to have a close box only on the active tab? (aka
>> wxAUI_NB_CLOSE_ON_ACTIVE_TAB)
>
> Yes.
>
>> With the perspective code, yes. I need to better understand it to code
>> it for the server status window.
>
> It's pretty simple really - you've got most of it, just the toggle
> functions to add to switch things on or off via the menu. We also used
> to add event handlers for OnSize and OnEraseBackground to fix some
> display issues, but I'm not sure if thats still a problem with moden
> versions of wxWidgets.
>

Done.

> Some comments on the patch:
>
> - The form setup code is a pretty large hunk of code. Can we get some
> more comments and blank lines in there to break things up a little?

It should be done. There's more comments and the code is a bit factored.

> - The form underneath the AUI controls seems to have some drawing
> issues on XP. The refresh bar is just about unusable for example.
>

Yeah. Even with this new patch, I still have this issue and no idea how
to fix this. I tried the OnSize and OnEraseBackground methods, but that
didn't fix it.

> Thats about it for the moment - nothing too serious.
>

I attached the new patch version.

--
Guillaume.
http://www.postgresqlfr.org
http://dalibo.com