| From: | Magnus Hagander <magnus(at)hagander(dot)net> |
|---|---|
| To: | ITAGAKI Takahiro <itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp> |
| Cc: | Hiroshi Inoue <inoue(at)tpf(dot)co(dot)jp>, Hiroshi Saito <z-saito(at)guitar(dot)ocn(dot)ne(dot)jp>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Solve a problem of LC_TIME of windows. |
| Date: | 2009-01-09 13:05:03 |
| Message-ID: | 49674B7F.1030307@hagander.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers pgsql-patches |
ITAGAKI Takahiro wrote:
> Hiroshi Inoue <inoue(at)tpf(dot)co(dot)jp> wrote:
>
>> Seems LC_CTYPE and LC_TIME should be convertible even though we use
>> wcsftime (which internally calls strftime?).
>
> Ok, wcsftime() requries both LC_TIME and LC_CTYPE are the same setting
> (at least encoding) on Windows.
>
> The attached patch is an updated version to fix cache_locale_time().
> Now it sets LC_TIME and LC_CTYPE to the specified locale and restore
> them at end of the function. I tested the patch on Windows XP Japanese
> Edition (SJIS) with UTF-8 and EUCJP databases, and worked expectedly.
>
> "#ifdef WIN32" codes seems to be ugly in the patch,
> but I have no other idea...
I have applied this version of the patch (with only a minor further
addition to the comment).
Thank you all for your work and patience in getting this fixed! Let's
hope it stays fixed :-)
//Magnus
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Simon Riggs | 2009-01-09 13:08:32 | Re: Hot standby, slot ids and stuff |
| Previous Message | Heikki Linnakangas | 2009-01-09 12:38:05 | Re: Hot standby, slot ids and stuff |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Hiroshi Saito | 2009-01-09 15:57:08 | Re: Solve a problem of LC_TIME of windows. |
| Previous Message | Hiroshi Inoue | 2009-01-08 21:31:48 | Re: Solve a problem of LC_TIME of windows. |