| From: | Magnus Hagander <magnus(at)hagander(dot)net> |
|---|---|
| To: | Alex Hunsaker <badalex(at)gmail(dot)com> |
| Cc: | Andrew Chernow <ac(at)esilo(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: new libpq SSL connection option |
| Date: | 2008-12-29 23:25:17 |
| Message-ID: | 49595C5D.5050006@hagander.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Alex Hunsaker wrote:
> On Sat, Dec 27, 2008 at 11:50, Andrew Chernow <ac(at)esilo(dot)com> wrote:
>> Why does pqGetHomeDirectory have to succeed to use conn->sslrootcert. Maybe
>> this should be an OR of the two since sslrootcert is not dependent on
>> homedir?
>>
>> around line 970 src/interfaces/libpq/fe-secure.c
>>
>> if (conn->sslrootcert || pqGetHomeDirectory(homedir, sizeof(homedir)))
>
> Certainly, did we miss anywhere else?
I agree it looks strange.
That said, have you actually seen a case where pqGetHomeDirectory()
fails? Or did you just notice the code?
//Magnus
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David Rowley | 2008-12-29 23:32:33 | Re: Windowing Function Patch Review -> Standard Conformance |
| Previous Message | Tom Lane | 2008-12-29 23:13:00 | Re: Windowing Function Patch Review -> Standard Conformance |