From:
Magnus Hagander <magnus(at)hagander(dot)net>
To:
Robert Haas <robertmhaas(at)gmail(dot)com>
Cc:
Peter Eisentraut <peter_e(at)gmx(dot)net>, pgsql-hackers(at)postgresql(dot)org,
Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Subject:
Re: Re: [COMMITTERS] pgsql: Add support for matching wildcard
server certificates to the new
Date:
2008-12-01 15:41:16
Message-ID:
4934059C.2010200@hagander.net (view raw or flat )
Thread:
2008-11-24 09:15:16 from mha(at)postgresql(dot)org (Magnus Hagander)
2008-11-24 13:37:30 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2008-11-24 13:43:09 from Magnus Hagander <magnus(at)hagander(dot)net>
2008-11-24 13:49:55 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2008-11-24 13:55:03 from Magnus Hagander <magnus(at)hagander(dot)net>
2008-11-24 14:40:00 from Peter Eisentraut <peter_e(at)gmx(dot)net>
2008-11-24 14:55:17 from Magnus Hagander <magnus(at)hagander(dot)net>
2008-11-24 21:26:41 from Peter Eisentraut <peter_e(at)gmx(dot)net>
2008-11-24 21:30:14 from Peter Eisentraut <peter_e(at)gmx(dot)net>
2008-11-28 15:13:54 from Magnus Hagander <magnus(at)hagander(dot)net>
2008-11-28 16:56:35 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2008-11-28 18:33:54 from Magnus Hagander <magnus(at)hagander(dot)net>
2008-11-28 18:48:38 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2008-11-29 13:43:23 from Magnus Hagander <magnus(at)hagander(dot)net>
2008-11-28 22:08:42 from Peter Eisentraut <peter_e(at)gmx(dot)net>
2008-11-29 13:49:35 from Magnus Hagander <magnus(at)hagander(dot)net>
2008-11-29 15:56:42 from "Robert Haas" <robertmhaas(at)gmail(dot)com>
2008-12-01 14:49:38 from Magnus Hagander <magnus(at)hagander(dot)net>
2008-12-01 15:02:39 from "Robert Haas" <robertmhaas(at)gmail(dot)com>
2008-12-01 15:05:50 from Magnus Hagander <magnus(at)hagander(dot)net>
2008-12-01 15:34:46 from "Robert Haas" <robertmhaas(at)gmail(dot)com>
2008-12-01 15:31:46 from Magnus Hagander <magnus(at)hagander(dot)net>
2008-12-01 15:38:53 from "Robert Haas" <robertmhaas(at)gmail(dot)com>
2008-12-01 15:41:16 from Magnus Hagander <magnus(at)hagander(dot)net>
2008-12-01 17:10:15 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2008-12-01 17:18:41 from Magnus Hagander <magnus(at)hagander(dot)net>
2008-12-01 17:28:32 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2008-11-24 15:11:25 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Lists:
pgsql-committers pgsql-hackers
I could assign it to a variable, but won't the compiler just optimize
that away?
//Magnus
Robert Haas wrote:
> Looks good to me, except for a somewhat excessive number of calls to
> strlen() on the same input data.
>
> ...Robert
>
> On Mon, Dec 1, 2008 at 10:31 AM, Magnus Hagander <magnus(at)hagander(dot)net> wrote:
>> Magnus Hagander wrote:
>>> I think I agree with the idea that we should match wildcards only at the
>>> beginning of the name *for now*, and then see what people actually
>>> request :-) I'm less sure about the single-pathname-component part, but
>>> the argument around backwards compatible is certainly a very valid one..
>> Here's one that (I think) does that. For every step, the code becomes
>> simpler - which I like when it comes to security code :)
>>
>> //Magnus
>>
>>
In response to
Responses
pgsql-hackers by date
Next :From: Robert HaasDate: 2008-12-01 15:46:49Subject : Re: New to_timestamp implementation is pretty strictPrevious :From : Robert HaasDate : 2008-12-01 15:38:53Subject : Re: Re: [COMMITTERS] pgsql: Add support for matching wildcard server certificates to the new
pgsql-committers by date
Next :From: Tom LaneDate: 2008-12-01 17:06:21Subject : pgsql: Ensure that the contents of a holdable cursor don't depend on Previous :From : Robert HaasDate : 2008-12-01 15:38:53Subject : Re: Re: [COMMITTERS] pgsql: Add support for matching wildcard server certificates to the new
