| From: | Magnus Hagander <magnus(at)hagander(dot)net> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | Peter Eisentraut <peter_e(at)gmx(dot)net>, pgsql-hackers(at)postgresql(dot)org, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Subject: | Re: Re: [COMMITTERS] pgsql: Add support for matching wildcard server certificates to the new |
| Date: | 2008-12-01 15:41:16 |
| Message-ID: | 4934059C.2010200@hagander.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
I could assign it to a variable, but won't the compiler just optimize
that away?
//Magnus
Robert Haas wrote:
> Looks good to me, except for a somewhat excessive number of calls to
> strlen() on the same input data.
>
> ...Robert
>
> On Mon, Dec 1, 2008 at 10:31 AM, Magnus Hagander <magnus(at)hagander(dot)net> wrote:
>> Magnus Hagander wrote:
>>> I think I agree with the idea that we should match wildcards only at the
>>> beginning of the name *for now*, and then see what people actually
>>> request :-) I'm less sure about the single-pathname-component part, but
>>> the argument around backwards compatible is certainly a very valid one..
>> Here's one that (I think) does that. For every step, the code becomes
>> simpler - which I like when it comes to security code :)
>>
>> //Magnus
>>
>>
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2008-12-01 17:06:21 | pgsql: Ensure that the contents of a holdable cursor don't depend on |
| Previous Message | Robert Haas | 2008-12-01 15:38:53 | Re: Re: [COMMITTERS] pgsql: Add support for matching wildcard server certificates to the new |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2008-12-01 15:46:49 | Re: New to_timestamp implementation is pretty strict |
| Previous Message | Robert Haas | 2008-12-01 15:38:53 | Re: Re: [COMMITTERS] pgsql: Add support for matching wildcard server certificates to the new |