Re: Re: [COMMITTERS] pgsql: Silence compiler warning about ignored return value.

Magnus Hagander wrote:
> Heikki Linnakangas wrote:
>> Magnus Hagander wrote:
>>> Log Message:
>>> -----------
>>> Silence compiler warning about ignored return value. Our comment already
>>> clearly stated that we are aware that we're ignoring it.
>> I think the usual way is to call the function like:
>>
>> (void) function_with_return_value()
>
> I tried that first, of course. gcc is too smart about that - it still
> throws the warning in this case.

Well, the warning is explicitly put in there for this specific function
because you are supposed to process the return value. I'm sure a more
smarter compiler would even warn "variable is assigned a value that is
never used". ;-) (Note that gcc in general doesn't work about unused
return values, only for those functions that glibc explicitly marks as
candidates.)

It looks like you are building in fortify mode? I tried that a while
ago and got a few more warnings. Are we trying to be fortify clean, and
if so, what is our approach?

Also, considering my recent complaint about various brittleness in the
regression test driver, more well hidden ignorings of errors are not
exactly my favorite solution.