From: | Andrew Chernow <ac(at)esilo(dot)com> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: libpq-events windows gotcha |
Date: | 2008-11-14 12:15:47 |
Message-ID: | 491D6BF3.9030700@esilo.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
>>>
>>> 4. what we do now, but document loudly that PGEventProc must be static.
>>> If it can't be referenced outside the DLL directly then the issue can't
>>> arise. If you need the function address for calls to PQinstanceData, an
>>> implementor can create a public function that returns their private
>>> PGEventProc address.
>
>> Do you have a preference form the list above, or an another idea? If
>> not, we would probably implement #1. Although, the simplest thing is #4
>> which leaves everything as is and updates the sgml docs with a strong
>> warning to implementors.
>
> On the whole I vote for #4 out of these.
>
I attached a patch for the docs. Its documented as a NOTE to the
PGEventProc.
--
Andrew Chernow
eSilo, LLC
every bit counts
http://www.esilo.com/
Attachment | Content-Type | Size |
---|---|---|
libpq-events.patch | text/plain | 1.3 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Michael Meskes | 2008-11-14 12:40:57 | Re: gram.y => preproc.y |
Previous Message | Alvaro Herrera | 2008-11-14 12:03:34 | Re: gram.y => preproc.y |