Re: Last call for back-branch fixes

From: "Greg Sabino Mullane" <greg(at)turnstep(dot)com>
To: pgsql-hackers(at)postgresql(dot)org
Subject: Re: Last call for back-branch fixes
Date: 2005-10-04 01:28:41
Message-ID: 4917631f3b4cbf79ae11d41642078416@biglumber.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

> ! (void) sprintf((char *) rp, "\\\\%03o", *vp);
> ! (void) snprintf((char *) rp, 6, "\\\\%03o", *vp);

> Hardly looks like a critical fix, or even a needed one. Why bother?

No, not critical. Just something that tripped me up a few months ago when
writing some code based on this section, and I finally remembered it when
I saw your email. It's more of a nice to have, as the surrounding code
should prevent the %03o from making more than 3 characters.

- --
Greg Sabino Mullane greg(at)turnstep(dot)com
PGP Key: 0x14964AC8 200510032127
http://biglumber.com/x/web?pk=2529DF6AB8F79407E94445B4BC9B906714964AC8
-----BEGIN PGP SIGNATURE-----

iD8DBQFDQdq9vJuQZxSWSsgRAgeRAKCujcqJFtPf+LSlQ17BBCbGmfelmACgr30s
5OFfHfL3evrwV/FQI/XRMJI=
=ZTcO
-----END PGP SIGNATURE-----

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Marc G. Fournier 2005-10-04 01:34:24 New Point Releases Available
Previous Message Christopher Kings-Lynne 2005-10-04 01:24:56 Re: [COMMITTERS] pgsql: Fix procedure for updating nextval() defaults