| From: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | KaiGai Kohei <kaigai(at)ak(dot)jp(dot)nec(dot)com>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: The suppress_redundant_updates_trigger() works incorrectly |
| Date: | 2008-11-05 19:15:57 |
| Message-ID: | 4911F0ED.1000008@dunslane.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Tom Lane wrote:
> I wrote:
>
>> Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
>>
>>> OK, that will be easy enough. I assume I should still put InvalidOid
>>> back again afterwards, in case someone downstream relies on it.
>>>
>
>
>> Can't imagine what ...
>>
>
> Actually ... what *could* change in the future is that we might support
> UPDATE'ing the OID to a different value. So what the code probably
> needs to do is something like
>
> if (relation->rd_rel->relhasoids &&
> !OidIsValid(HeapTupleGetOid(newtup)))
> HeapTupleSetOid(newtup, HeapTupleGetOid(oldtup));
>
> (details stolen from heap_update)
>
>
>
Your wish is my command. Done.
cheers
andrew
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Heikki Linnakangas | 2008-11-05 19:49:08 | Toast bug in CVS HEAD |
| Previous Message | Andrew Dunstan | 2008-11-05 18:50:33 | Re: The suppress_redundant_updates_trigger() works incorrectly |