From: | Guillaume Lelarge <guillaume(at)lelarge(dot)info> |
---|---|
To: | Bernd Helmle <mailings(at)oopsware(dot)de> |
Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Patch for ALTER DATABASE WITH TABLESPACE |
Date: | 2008-11-04 20:15:15 |
Message-ID: | 4910AD53.3090107@lelarge.info |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Bernd Helmle a écrit :
> --On Dienstag, November 04, 2008 14:56:44 -0500 Tom Lane
> <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>
> [...]
>
>>
>> Not sure what Bernd tried exactly, but it can be done.
>>
>
> Cool, i didn't recognize the obvious possibility to add a separate rule
> for this. I've just extended the alterdb_opt_item with SET TABLESPACE,
> which lead to a shift/reduce.
>
>> I see the point about the parallel to CREATE DATABASE, but on the other
>> hand we also have ALTER DATABASE SET for parameters. I suspect people
>> are more likely to expect the SET syntax.
>>
>
> Yes, that seems logical to me, too. So i think we should go for it.
> Guillaume?
>
I'm OK for this. I also think it's a better way, more logical to do it.
Should I provide a complete new patch with Bernd's and Tom's changes?
--
Guillaume.
http://www.postgresqlfr.org
http://dalibo.com
From | Date | Subject | |
---|---|---|---|
Next Message | Kenneth Marshall | 2008-11-04 20:26:55 | Re: [PATCHES] updated hash functions for postgresql v1 |
Previous Message | Bernd Helmle | 2008-11-04 20:12:04 | Re: Patch for ALTER DATABASE WITH TABLESPACE |