Re: Shouldn't pg_settings.enumvals be array of text?

From: Magnus Hagander <magnus(at)hagander(dot)net>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-hackers(at)postgreSQL(dot)org
Subject: Re: Shouldn't pg_settings.enumvals be array of text?
Date: 2008-10-06 14:08:06
Message-ID: 48EA1BC6.7010705@hagander.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-www

Tom Lane wrote:
> Currently, pg_settings.enumvals presents a list of strings formatted in
> an ad-hoc manner. Shouldn't we be presenting this as text[], so that
> clients don't need special-purpose code to break it apart?
>
> Another possible argument is that the values ought to be separated by
> newlines instead of ", ", which would still be a special-purpose format
> but it would probably look better in modern psql versions. At least it
> wouldn't be contributing to the problem of the view's output being
> ridiculously wide.
>
> Comments?

Agreed, it can certainly be bettered. text[] seems to be the cleanest,
but then we still have the issue with wide output in psql, no? But
should we really design the view around the single use-case of psql? You
can still just omit that column from the SELECT if you want...

//Magnus

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2008-10-06 14:15:11 Re: Shouldn't pg_settings.enumvals be array of text?
Previous Message Tom Lane 2008-10-06 14:01:01 Shouldn't pg_settings.enumvals be array of text?

Browse pgsql-www by date

  From Date Subject
Next Message Tom Lane 2008-10-06 14:15:11 Re: Shouldn't pg_settings.enumvals be array of text?
Previous Message Tom Lane 2008-10-06 14:01:01 Shouldn't pg_settings.enumvals be array of text?