| From: | Magnus Hagander <magnus(at)hagander(dot)net> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Brendan Jurd <direvus(at)gmail(dot)com>, "D'Arcy J(dot)M(dot) Cain" <darcy(at)druid(dot)net>, Bruce Momjian <bruce(at)momjian(dot)us>, Josh Berkus <josh(at)agliodbs(dot)com>, Gregory Stark <stark(at)enterprisedb(dot)com>, PG Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Parsing of pg_hba.conf and authentication inconsistencies |
| Date: | 2008-09-15 20:55:25 |
| Message-ID: | 48CECBBD.9040001@hagander.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Tom Lane wrote:
> Magnus Hagander <magnus(at)hagander(dot)net> writes:
>>>> Or perhaps the DETAIL portion would be more appropriate as a CONTEXT?
>>> +1
>
>> Is this the proper syntax for errcontext() messags?
>
> Hmm, I think I'd suggest following the wording already in use in
> ts_locale.c:
>
> errcontext("line %d of configuration file \"%s\"",
> stp->lineno,
> stp->filename);
>
> if only to save translation effort.
>
> Also, in the last example, don't include the line number in the
> errmsg. Otherwise it looks ok to me.
Updated and applied.
//Magnus
| From | Date | Subject | |
|---|---|---|---|
| Next Message | R Mayer | 2008-09-15 21:36:18 | 8.3 vs HEAD difference in Interval output? |
| Previous Message | Simon Riggs | 2008-09-15 20:27:11 | Re: Transaction Snapshots and Hot Standby |