| From: | Magnus Hagander <magnus(at)hagander(dot)net> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Brendan Jurd <direvus(at)gmail(dot)com>, "D'Arcy J(dot)M(dot) Cain" <darcy(at)druid(dot)net>, Bruce Momjian <bruce(at)momjian(dot)us>, Josh Berkus <josh(at)agliodbs(dot)com>, Gregory Stark <stark(at)enterprisedb(dot)com>, PG Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Parsing of pg_hba.conf and authentication inconsistencies |
| Date: | 2008-09-15 13:46:45 |
| Message-ID: | 48CE6745.5000603@hagander.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Tom Lane wrote:
> "Brendan Jurd" <direvus(at)gmail(dot)com> writes:
>> Cool. I had a look at the commitdiff and I think you missed one of
>> the error messages (it's still all on one line). It's at
>> src/backend/libpq/hba.c line 841. I've included a patch to split it
>> up below.
>
> Hm, that doesn't seem like a great improvement --- in particular, it
> violates the style guideline that detail messages should be complete
> sentences.
>
> I think the error text is all right as-is, really.
I think I need to hit myself over the head with those guidelines
repeatedly, because I think the *changed* messages are in violation of
this, and need to be changed again...
//Magnus
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Simon Riggs | 2008-09-15 13:49:59 | Re: Transaction Snapshots and Hot Standby |
| Previous Message | Tom Lane | 2008-09-15 13:41:04 | Re: Parsing of pg_hba.conf and authentication inconsistencies |